fix: Track transaction item open events

[usame-algan]

What it solves

Fix for #2543

This will significantly reduce the number of events that are tracked due to users opening a single transaction view (which is already tracked by a page view event).

How this PR fixes it

• Removes Fetch transaction details event
• Tracks Expand transaction item event whenever the user expands a transaction item

How to test it

1. Open a transaction history
2. Click on a transaction to expand
3. Observe that the event is tracked
4. Close the transaction and open it again
5. Observe that the event is tracked again
6. Open a single transaction view
7. Observe that no event for fetch tx details is tracked

[github-actions]

Branch preview

✅ Deploy successful!

https://fetch_details_event--walletweb.review-wallet-web.5afe.dev

[github-actions]

ESLint Summary View Full Report

Annotations are provided inline on the Files Changed tab. You can also see all annotations that were generated on the annotations page.

Type	Occurrences	Fixable
Errors	0	0
Warnings	0	0
Ignored	0	N/A

• Result: ✅ success
• Annotations: 0 total

---

^{Report generated by eslint-plus-action}

[katspaugh]

That's a negation, isn't it? Why do we even track this event? We should track clicks on the accordeon, not the fetch.

[usame-algan]

I also considered tracking this event on the accordion click but with the current structure it doesn't seem possible since the fetch is in a nested component and with the accordion click we can only know if it was opened or closed but not if we already fetched the data before. Do you think we should track the first accordion open in general regardless of the fetch status?

[katspaugh]

Yes. I think we should track the user intention, not how our app interpreted it.

[usame-algan]

I changed it so we track the accordion open once. I also renamed the event to better fit the new purpose.

[francovenica]

Ok so I did't understand at first since I don't remember at heart what events we track with those actions, so I'll leave this comment here for the sake of documentation on "how it was" vs "how it is right now"

This event used to track whenever you expand a tx item and it would only track once. Also the same event tracks whenever you open a tx in the individual view with its deep link.

I've checked now that a different event is tracked when the tx is expanded and no "Fetch" event is tracked when expanding a tx item nor when it is opened with a deep link

Looks good to me