Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add sidebar design to welcome page #2601

Merged
merged 2 commits into from
Oct 6, 2023

Conversation

schmanu
Copy link
Member

@schmanu schmanu commented Oct 6, 2023

What it solves

Adds design for Welcome page sidebar

How to test it

Got to welcome page and show the sidebar

Screenshots

Screenshot 2023-10-06 at 15 30 28
Screenshot 2023-10-06 at 15 30 20

Checklist

  • I've tested the branch on mobile 📱
  • I've documented how it affects the analytics (if at all) 📊
  • I've written a unit/e2e test for it (if applicable) 🧑‍💻

@github-actions
Copy link

github-actions bot commented Oct 6, 2023

Branch preview

✅ Deploy successful!

https://seedless_welcome_sidebar--walletweb.review-wallet-web.5afe.dev

@schmanu schmanu requested a review from iamacook October 6, 2023 13:48
@github-actions
Copy link

github-actions bot commented Oct 6, 2023

ESLint Summary View Full Report

Annotations are provided inline on the Files Changed tab. You can also see all annotations that were generated on the annotations page.

Type Occurrences Fixable
Errors 0 0
Warnings 0 0
Ignored 0 N/A
  • Result: ✅ success
  • Annotations: 0 total

Report generated by eslint-plus-action

src/components/welcome/NewSafe.tsx Outdated Show resolved Hide resolved
src/components/welcome/NewSafe.tsx Outdated Show resolved Hide resolved
src/components/welcome/styles.module.css Outdated Show resolved Hide resolved
src/components/welcome/NewSafe.tsx Outdated Show resolved Hide resolved
@schmanu schmanu requested a review from iamacook October 6, 2023 14:12
@schmanu schmanu merged commit 1a161da into web3authcoresdk Oct 6, 2023
6 of 7 checks passed
@schmanu schmanu deleted the seedless-welcome-sidebar branch October 6, 2023 17:22
@github-actions github-actions bot locked and limited conversation to collaborators Oct 6, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants