Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: enable manualSync, commit MFA changes in batches #2600

Merged
merged 6 commits into from
Oct 9, 2023

Conversation

schmanu
Copy link
Member

@schmanu schmanu commented Oct 6, 2023

What it solves

Without manualSync each factor change is commited by itself.
This causes issues if multiple changes are necessary (i.e. for enabling MFA) as each individual commit could fail and lead to inconsistent states

How this PR fixes it

  • Enables manualSync
  • Commits changes in logical batches

How to test it

  • Create a new fresh signer with a google login
  • Go to settings -> signer account
  • Set a password
  • Change the password / device storage setup
  • Login on another browser and recover the account

Checklist

  • I've tested the branch on mobile 📱
  • I've documented how it affects the analytics (if at all) 📊
  • I've written a unit/e2e test for it (if applicable) 🧑‍💻

@github-actions
Copy link

github-actions bot commented Oct 6, 2023

Branch preview

✅ Deploy successful!

https://seedless_manual_sync--walletweb.review-wallet-web.5afe.dev

@github-actions
Copy link

github-actions bot commented Oct 6, 2023

ESLint Summary View Full Report

Annotations are provided inline on the Files Changed tab. You can also see all annotations that were generated on the annotations page.

Type Occurrences Fixable
Errors 0 0
Warnings 0 0
Ignored 0 N/A
  • Result: ✅ success
  • Annotations: 0 total

Report generated by eslint-plus-action

@schmanu schmanu requested a review from usame-algan October 9, 2023 11:24
@schmanu schmanu merged commit 5ab369e into web3authcoresdk Oct 9, 2023
@schmanu schmanu deleted the seedless-manual-sync branch October 9, 2023 15:29
@github-actions github-actions bot locked and limited conversation to collaborators Oct 9, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants