Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: don't cut off DApp icon #2594

Merged
merged 1 commit into from
Oct 5, 2023
Merged

fix: don't cut off DApp icon #2594

merged 1 commit into from
Oct 5, 2023

Conversation

iamacook
Copy link
Member

@iamacook iamacook commented Oct 5, 2023

What it solves

Resolves cut off logo

How this PR fixes it

The full logo is now shown in the header when connected to a DApp.

How to test it

Connect to a DApp via native WC and observe no cut off logo.

Checklist

  • I've tested the branch on mobile 📱
  • I've documented how it affects the analytics (if at all) 📊
  • I've written a unit/e2e test for it (if applicable) 🧑‍💻

@iamacook iamacook requested a review from katspaugh October 5, 2023 13:17
@iamacook iamacook self-assigned this Oct 5, 2023
@github-actions
Copy link

github-actions bot commented Oct 5, 2023

Branch preview

✅ Deploy successful!

https://wc_logo--walletweb.review-wallet-web.5afe.dev

@github-actions
Copy link

github-actions bot commented Oct 5, 2023

ESLint Summary View Full Report

Annotations are provided inline on the Files Changed tab. You can also see all annotations that were generated on the annotations page.

Type Occurrences Fixable
Errors 0 0
Warnings 0 0
Ignored 0 N/A
  • Result: ✅ success
  • Annotations: 0 total

Report generated by eslint-plus-action

@iamacook iamacook merged commit c53310e into nect Oct 5, 2023
7 of 10 checks passed
@iamacook iamacook deleted the wc-logo branch October 5, 2023 13:50
@github-actions github-actions bot locked and limited conversation to collaborators Oct 5, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants