Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Show recommended nonce when nonce is 0, fix msgSummary layout #2562

Merged
merged 1 commit into from
Sep 28, 2023

Conversation

usame-algan
Copy link
Member

@usame-algan usame-algan commented Sep 28, 2023

What it solves

Fixes #2546 (comment), #2546 (comment)

How this PR fixes it

  • Checks the recommendedNonce for undefined
  • Adds correct css class to MsgSummary

How to test it

  1. Create a new transaction in a new safe
  2. Observe the nonce form showing 0
  3. Go to Messages with existing messages there
  4. Observe no overlaps

Screenshots

Screenshot 2023-09-28 at 09 11 26 Screenshot 2023-09-28 at 09 12 53

Checklist

  • I've tested the branch on mobile 📱
  • I've documented how it affects the analytics (if at all) 📊
  • I've written a unit/e2e test for it (if applicable) 🧑‍💻

@github-actions
Copy link

github-actions bot commented Sep 28, 2023

Branch preview

✅ Deploy successful!

https://fix_nonce--walletweb.review-wallet-web.5afe.dev

@github-actions
Copy link

ESLint Summary View Full Report

Annotations are provided inline on the Files Changed tab. You can also see all annotations that were generated on the annotations page.

Type Occurrences Fixable
Errors 0 0
Warnings 0 0
Ignored 0 N/A
  • Result: ✅ success
  • Annotations: 0 total

Report generated by eslint-plus-action

@usame-algan usame-algan mentioned this pull request Sep 28, 2023
@usame-algan usame-algan merged commit a44252b into release/1.19.0 Sep 28, 2023
7 checks passed
@usame-algan usame-algan deleted the fix-nonce branch September 28, 2023 07:33
@github-actions github-actions bot locked and limited conversation to collaborators Sep 28, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants