fix: only delete all preferences per chain #2556
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What it solves
Resolves #2546 (comment)
How this PR fixes it
deleteAllPreferences
is has been replaced withdeleteAllChainPreferences
, which clears preferences according to a providedchainId
according to the device unregistration (also perchainId
).A loading indicator has also been added to the global preferences "Save" button.
How to test it
During the following registrations, a loading indicator should appear in the "Save" button:
Checklist