Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Hide txInfo when displaying human description in batch tx #2549

Merged
merged 1 commit into from
Sep 26, 2023

Conversation

usame-algan
Copy link
Member

What it solves

Part of #2011

How this PR fixes it

  • Hides the TxInfo in the batch view when human-readable descriptions are displayed

How to test it

  1. Open a Safe and create a batch (e.g. with transfers)
  2. Observe that if human-readable descriptions are visible, there is no second column

Screenshots

Screenshot 2023-09-26 at 14 07 10 Screenshot 2023-09-26 at 14 07 33

Checklist

  • I've tested the branch on mobile 📱
  • I've documented how it affects the analytics (if at all) 📊
  • I've written a unit/e2e test for it (if applicable) 🧑‍💻

@github-actions
Copy link

github-actions bot commented Sep 26, 2023

Branch preview

✅ Deploy successful!

https://fix_human_description_batch--walletweb.review-wallet-web.5afe.dev

@github-actions
Copy link

ESLint Summary View Full Report

Annotations are provided inline on the Files Changed tab. You can also see all annotations that were generated on the annotations page.

Type Occurrences Fixable
Errors 0 0
Warnings 0 0
Ignored 0 N/A
  • Result: ✅ success
  • Annotations: 0 total

Report generated by eslint-plus-action

@usame-algan usame-algan merged commit f270c7e into dev Sep 26, 2023
9 checks passed
@usame-algan usame-algan deleted the fix-human-description-batch branch September 26, 2023 12:46
@github-actions github-actions bot locked and limited conversation to collaborators Sep 26, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants