Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Remove human description from dashboard due to lack of space #2547

Merged
merged 1 commit into from
Sep 26, 2023

Conversation

usame-algan
Copy link
Member

What it solves

Resolves #2011

How this PR fixes it

  • Removes human-readable descriptions from the dashboard widget

How to test it

  1. Open a Safe with queued transactions
  2. Navigate to the dashboard
  3. Observe the transactions without human-readable description

Screenshots

Screenshot 2023-09-26 at 09 17 06

Checklist

  • I've tested the branch on mobile 📱
  • I've documented how it affects the analytics (if at all) 📊
  • I've written a unit/e2e test for it (if applicable) 🧑‍💻

@github-actions
Copy link

github-actions bot commented Sep 26, 2023

Branch preview

✅ Deploy successful!

https://human_description_dashboard--walletweb.review-wallet-web.5afe.dev

@github-actions
Copy link

github-actions bot commented Sep 26, 2023

ESLint Summary View Full Report

Annotations are provided inline on the Files Changed tab. You can also see all annotations that were generated on the annotations page.

Type Occurrences Fixable
Errors 0 0
Warnings 0 0
Ignored 0 N/A
  • Result: ✅ success
  • Annotations: 0 total

Report generated by eslint-plus-action

@usame-algan usame-algan force-pushed the human-description-dashboard branch from 0156078 to 2bac624 Compare September 26, 2023 08:34
Copy link
Member

@katspaugh katspaugh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@katspaugh katspaugh merged commit 019ecae into dev Sep 26, 2023
@katspaugh katspaugh deleted the human-description-dashboard branch September 26, 2023 09:17
@github-actions github-actions bot locked and limited conversation to collaborators Sep 26, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

[EPIC] Human-readable transactions
2 participants