Feat: new connect button + deprecate mobile pairing #2544
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Branch preview✅ Deploy successful! |
ESLint Summary View Full Report
Report generated by eslint-plus-action |
|
@TanyaEfremova could you check the design for this? |
usame-algan
reviewed
Sep 25, 2023
src/components/common/PairingDetails/PairingDeprecationWarning.tsx
Outdated
Show resolved
Hide resolved
iamacook
reviewed
Sep 25, 2023
src/components/common/PairingDetails/PairingDeprecationWarning.tsx
Outdated
Show resolved
Hide resolved
iamacook
reviewed
Sep 25, 2023
src/components/common/PairingDetails/PairingDeprecationWarning.tsx
Outdated
Show resolved
Hide resolved
|
@katspaugh Looks good to me! |
iamacook
approved these changes
Sep 26, 2023
|
Since there's no logic changes in this PR, I'll merge and we'll test it on the RC branch. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What it solves
Resolves #2540
How this PR fixes it
Removes the mobile pairing from the Connect wallet popup, and the popup itself along with it. It will now show a Connect button directly in the header.
This PR also adds a deprecation warning in the mobile pairing onboard modal. The wording and the date to be adjusted.