Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Add AB test for human-readable transactions #2543

Merged
merged 4 commits into from
Sep 25, 2023
Merged

Conversation

usame-algan
Copy link
Member

@usame-algan usame-algan commented Sep 25, 2023

What it solves

Part of #2011

How this PR fixes it

  • Adds A/B testing for human-readable descriptions in the history/queue
  • Adds a new event for Fetching transaction details
  • Fixes slight (4px difference) column alignment issue on the date between human-readable transactions and other ones

How to test it

  1. Open a Safe
  2. Observe there is a new local storage key called SAFE_v2__AB_human-readable
  3. Navigate to the history/queue
  4. Switch the key from true to false or vice versa
  5. Observe the history/queue changes layout
  6. Remove the local storage key and reload the page until the value changes, if its false observe no abTest key in GTM otherwise observe the abTest key in GTM saying human-readable
  7. Observe there is a new event Fetch transaction details when opening a transaction in the history for the first time

Screenshots

Screenshot 2023-09-25 at 16 33 03 Screenshot 2023-09-25 at 16 33 18

Checklist

  • I've tested the branch on mobile 📱
  • I've documented how it affects the analytics (if at all) 📊
  • I've written a unit/e2e test for it (if applicable) 🧑‍💻

@github-actions
Copy link

github-actions bot commented Sep 25, 2023

Branch preview

✅ Deploy successful!

https://track_human_readable--walletweb.review-wallet-web.5afe.dev

@github-actions
Copy link

github-actions bot commented Sep 25, 2023

ESLint Summary View Full Report

Annotations are provided inline on the Files Changed tab. You can also see all annotations that were generated on the annotations page.

Type Occurrences Fixable
Errors 0 0
Warnings 0 0
Ignored 0 N/A
  • Result: ✅ success
  • Annotations: 0 total

Report generated by eslint-plus-action

Copy link
Member

@katspaugh katspaugh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@francovenica
Copy link
Contributor

Looks good to me

Changing the AB_human_readable key in the LS shows/hides the human readable
I tried deleting the key and refreshing the page to see that sometimes it creates it with a value of true and false

I've checked in the GTM that the key "abTest = undefined" if the "AB_human_readable" key is false and as "abTest = human-readable" if the "AB_human_readable" key is true
image
image

@usame-algan usame-algan merged commit 58c9cc4 into dev Sep 25, 2023
9 checks passed
@usame-algan usame-algan deleted the track-human-readable branch September 25, 2023 20:11
@github-actions github-actions bot locked and limited conversation to collaborators Sep 25, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants