Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Update nextjs to v13.5 #2539

Merged
merged 9 commits into from
Oct 13, 2023
Merged

chore: Update nextjs to v13.5 #2539

merged 9 commits into from
Oct 13, 2023

Conversation

usame-algan
Copy link
Member

@usame-algan usame-algan commented Sep 25, 2023

What it solves

  • Update next to v13.5
  • Resolves broken imports as a result of the update
  • Replaces optimizeImports with experimental optimizePackageImports that doesn't require explicit mappings

How to test it

  • Navigating the app still works

Checklist

  • I've tested the branch on mobile 📱
  • I've documented how it affects the analytics (if at all) 📊
  • I've written a unit/e2e test for it (if applicable) 🧑‍💻

@github-actions
Copy link

github-actions bot commented Sep 25, 2023

Branch preview

✅ Deploy successful!

https://update_next--walletweb.review-wallet-web.5afe.dev

@github-actions
Copy link

github-actions bot commented Sep 25, 2023

ESLint Summary View Full Report

Annotations are provided inline on the Files Changed tab. You can also see all annotations that were generated on the annotations page.

Type Occurrences Fixable
Errors 0 0
Warnings 0 0
Ignored 0 N/A
  • Result: ✅ success
  • Annotations: 0 total

Report generated by eslint-plus-action

@francovenica
Copy link
Contributor

Looks good to me

I've just did a quick smoke through the site and everything worked fine
I've checked a share link in the safe apps Usame told me I should give a try.

@github-actions
Copy link

github-actions bot commented Oct 10, 2023

ESLint Summary View Full Report

Annotations are provided inline on the Files Changed tab. You can also see all annotations that were generated on the annotations page.

Type Occurrences Fixable
Errors 0 0
Warnings 0 0
Ignored 0 N/A
  • Result: ✅ success
  • Annotations: 0 total

Report generated by eslint-plus-action

@usame-algan
Copy link
Member Author

usame-algan commented Oct 10, 2023

Looks like this update causes issues with our patch for the next-pwa package. Updating the next-pwa package to v9.7.1 fixes it but breaks our patch. Updating the patch doesn't work anymore either so our service worker doesn't work. We will have to look further into this cc @iamacook

@katspaugh
Copy link
Member

Service workers seem to be fine w/o the patch.

Screenshot 2023-10-13 at 19 04 01

@katspaugh katspaugh merged commit c014ed7 into dev Oct 13, 2023
7 checks passed
@katspaugh katspaugh deleted the update-next branch October 13, 2023 17:06
@github-actions github-actions bot locked and limited conversation to collaborators Oct 13, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants