Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: close transaction modal if already on href #2527

Merged
merged 2 commits into from
Sep 22, 2023
Merged

Conversation

iamacook
Copy link
Member

What it solves

Resolves #2506

How this PR fixes it

If the NFT assets page is already open and "Send NFTs" is clicked in the transaction flow modal, the modal closes. The same for the "Contract interaction" button.

How to test it

Send NFTs

  1. Open the NFT asset page.
  2. Open the transaction modal.
  3. Click "Send NFTs".
  4. Observe the modal close.

Contract interaction

  1. Open the Transaction Builder.
  2. Open the transaction modal.
  3. Click "Contract interaction".
  4. Observe the modal close.

Checklist

  • I've tested the branch on mobile 📱
  • I've documented how it affects the analytics (if at all) 📊
  • I've written a unit/e2e test for it (if applicable) 🧑‍💻

@iamacook iamacook requested a review from katspaugh September 19, 2023 16:46
@iamacook iamacook self-assigned this Sep 19, 2023
@github-actions
Copy link

github-actions bot commented Sep 19, 2023

Branch preview

✅ Deploy successful!

https://tx_flow_nft_page--walletweb.review-wallet-web.5afe.dev

@github-actions
Copy link

ESLint Summary View Full Report

Annotations are provided inline on the Files Changed tab. You can also see all annotations that were generated on the annotations page.

Type Occurrences Fixable
Errors 0 0
Warnings 0 0
Ignored 0 N/A
  • Result: ✅ success
  • Annotations: 0 total

Report generated by eslint-plus-action

Copy link
Member

@katspaugh katspaugh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's only very slightly better than not doing anything on click, but at least something.

@francovenica
Copy link
Contributor

Looks good to me. It works as expected given the tickets description.

@iamacook iamacook merged commit 500c06a into dev Sep 22, 2023
9 checks passed
@iamacook iamacook deleted the tx-flow-nft-page branch September 22, 2023 14:47
@github-actions github-actions bot locked and limited conversation to collaborators Sep 22, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Nothing happens on SendNFT click when NFTs page was opened before new tx form
3 participants