-
Notifications
You must be signed in to change notification settings - Fork 456
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat: actionable pending txs on the Dashboard #2523
Conversation
Branch preview✅ Deploy successful! |
ESLint Summary View Full Report
Report generated by eslint-plus-action |
const actionable = useMemo(() => { | ||
return wallet | ||
? queuedTxns.filter( | ||
(tx) => isSignableBy(tx.transaction, wallet.address) || isExecutable(tx.transaction, wallet.address, safe), | ||
) | ||
: queuedTxns | ||
}, [wallet, queuedTxns, safe]) | ||
|
||
const txs = actionable.length ? actionable : queuedTxns |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit:
const actionable = useMemo(() => { | |
return wallet | |
? queuedTxns.filter( | |
(tx) => isSignableBy(tx.transaction, wallet.address) || isExecutable(tx.transaction, wallet.address, safe), | |
) | |
: queuedTxns | |
}, [wallet, queuedTxns, safe]) | |
const txs = actionable.length ? actionable : queuedTxns | |
const actionableTxns = useMemo(() => { | |
return wallet | |
? queuedTxns.filter( | |
(tx) => isSignableBy(tx.transaction, wallet.address) || isExecutable(tx.transaction, wallet.address, safe), | |
) | |
: queuedTxns | |
}, [wallet, queuedTxns, safe]) | |
const txs = actionable.length ? actionableTxns : queuedTxns |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice one 💯
Looks goood to me: I tested in a safe 3/3: |
Reopening this one because of an issue found: I created a tx with an owner and he can see the tx in the list. Is expected that he shouldn't see the tx since he already signed during creation The owner: (see if impersonator works) |
When there are no signable/executable txs, it will display any queued txs, so it's expected. |
What it solves
Part of #2510
How this PR fixes it
Shows only signable and executable queued txs, not just any queued txs. Also displays a ✔️ or 🚀 button if a tx can be executed or signed.