Cypress tests refactoring: PO model, safe app tests #2522

mike10ca · 2023-09-18T14:49:19Z

What it solves

Refactoring of existing Cypress tests

Resolves #2521

How this PR fixes it

PO model, safe apps tests, finish smoke tests, general refactoring

github-actions · 2023-09-18T14:49:37Z

Branch preview

✅ Deploy successful!

https://cypress_tests_refactor_p3--walletweb.review-wallet-web.5afe.dev

github-actions · 2023-09-18T14:50:39Z

ESLint Summary View Full Report

Annotations are provided inline on the Files Changed tab. You can also see all annotations that were generated on the annotations page.

Type	Occurrences	Fixable
Errors	0	0
Warnings	0	0
Ignored	0	N/A

Result: ✅ success
Annotations: 0 total

^{Report generated by eslint-plus-action}

# Conflicts: # cypress/e2e/pages/safeapps.pages.js # cypress/support/constants.js

katspaugh · 2023-09-21T20:24:09Z

.github/workflows/e2e.yml

@@ -9,7 +9,7 @@ concurrency:

 jobs:
  e2e:
-    runs-on: ubuntu-latest
+    runs-on: ubuntu-20.04


Why is this necessary? Latest is too new for Cypress? Or too old?

Our Cypress tests started to fail due to using latest runner image which conflicts with Cypress version. -latest tag uses image which might not be that stable as previous one, or be in pre-release mode.

Do we still need to pin the ubuntu version if we also upgraded cypress?

By specifying a version, we ensure that there will be some control over it. When this version is planned to become unavailable, we will hopefully receive notification that will give us enough time for updating to newer version of Cypress/resolve any conflicts instead of reacting to this when it was unexpected.

…date

cypress/e2e/pages/create_tx.pages.js

iamacook · 2023-09-22T12:17:57Z

cypress/e2e/pages/create_tx.pages.js

+  cy.contains(expandallbtnStr).click()
+}
+
+export function lickOnCollapseAllBtn() {


Suggested change

export function lickOnCollapseAllBtn() {

export function clickOnCollapseAllBtn() {

iamacook · 2023-09-22T12:18:10Z

cypress/e2e/pages/create_tx.pages.js

@@ -26,6 +27,8 @@ const editBtnStr = 'Edit'
 const executionParamsStr = 'Execution parameters'
 const noLaterStr = 'No, later'
 const signBtnStr = 'Sign'
+const expandallbtnStr = 'Expand all'


Suggested change

const expandallbtnStr = 'Expand all'

const expandAllBtnStr = 'Expand all'

iamacook · 2023-09-22T12:18:43Z

cypress/e2e/pages/safeapps.pages.js

@@ -0,0 +1,193 @@
+import * as constants from '../../support/constants'
+
+const searchappInput = 'input[id="search-by-name"]'


Suggested change

const searchappInput = 'input[id="search-by-name"]'

const searchAppInput = 'input[id="search-by-name"]'

iamacook · 2023-09-22T12:30:24Z

cypress/e2e/smoke/tx_history.cy.js

@@ -1,25 +1,37 @@
 import * as constants from '../../support/constants'
+import * as main from '../pages/main.page'
+import * as createtx from '../pages/create_tx.pages'


Suggested change

import * as createtx from '../pages/create_tx.pages'

import * as createTx from '../pages/create_tx.pages'

iamacook · 2023-09-22T12:31:06Z

cypress/support/constants.js

+export const invalidappUrl = 'https://my-invalid-custom-app.com/manifest.json'
+export const validappUrlJson = 'https://my-valid-custom-app.com/manifest.json'
+export const validappUrl = 'https://my-valid-custom-app.com'


Suggested change

export const invalidappUrl = 'https://my-invalid-custom-app.com/manifest.json'

export const validappUrlJson = 'https://my-valid-custom-app.com/manifest.json'

export const validappUrl = 'https://my-valid-custom-app.com'

export const invalidAppUrl = 'https://my-invalid-custom-app.com/manifest.json'

export const validAppUrlJson = 'https://my-valid-custom-app.com/manifest.json'

export const validAppUrl = 'https://my-valid-custom-app.com'

iamacook · 2023-09-22T12:31:24Z

cypress/support/constants.js

 export const proposeEndPoint = '/**/propose'
+export const appsEndPoint = '/**/safe-apps'


Suggested change

export const proposeEndPoint = '/**/propose'

export const appsEndPoint = '/**/safe-apps'

export const proposeEndpoint = '/**/propose'

export const appsEndpoint = '/**/safe-apps'

iamacook · 2023-09-22T12:32:44Z

cypress/support/constants.js

+  walletconnect: 'walletconnect',
+  customcontract: 'compose custom contract',
+  noresults: 'atextwithoutresults',


Suggested change

walletconnect: 'walletconnect',

customcontract: 'compose custom contract',

noresults: 'atextwithoutresults',

walletConnect: 'walletconnect',

customContract: 'compose custom contract',

noResults: 'atextwithoutresults',

iamacook · 2023-09-22T12:32:54Z

cypress/support/constants.js

+}
+
+export const tokenNames = {
+  wrapped_ether: 'Wrapped Ether',


Suggested change

wrapped_ether: 'Wrapped Ether',

wrappedEther: 'Wrapped Ether',

Co-authored-by: Aaron Cook <[email protected]>

Cypress tests refactoring: PO model, safe app tests

62d51df

mike10ca added 4 commits September 19, 2023 14:57

Cypress tests refactoring: PO model, safe app tests

c105c23

# Conflicts: # cypress/e2e/pages/safeapps.pages.js # cypress/support/constants.js

Fix tests

1e31579

Add missing constants

0aedd0b

Remove unused import

df2bfa8

mike10ca requested a review from katspaugh September 20, 2023 08:02

mike10ca marked this pull request as ready for review September 20, 2023 08:02

mike10ca and others added 3 commits September 21, 2023 10:21

Merge branch 'dev' into cypress-tests-refactor-p3

e0fb772

Fix tests, fix naming

f71b6cd

Update Ubuntu image

2dc4e01

katspaugh reviewed Sep 21, 2023

View reviewed changes

mike10ca added 5 commits September 22, 2023 09:32

Update Cypress version

1202fd8

Update yarn .lock file to reflect requied changes due to cypress v up…

d71f6b8

…date

Fix tests: manage local storage, set test isolation setting

2829ad0

Disable pendingactions tests, need to clarify logic

04c352e

Remove unused import

c42e53e

mike10ca requested a review from katspaugh September 22, 2023 11:16

iamacook reviewed Sep 22, 2023

View reviewed changes

mike10ca and others added 5 commits September 22, 2023 14:36

Update cypress/e2e/pages/create_tx.pages.js

84ba024

Co-authored-by: Aaron Cook <[email protected]>

Update cypress/e2e/pages/create_tx.pages.js

6f07fe8

Co-authored-by: Aaron Cook <[email protected]>

Address comments in PR

3c49bc1

Update constants

eccea6d

Disabling beamer test as it is not reliable

0d04552

iamacook approved these changes Sep 22, 2023

View reviewed changes

mike10ca self-assigned this Sep 22, 2023

katspaugh approved these changes Sep 25, 2023

View reviewed changes

katspaugh merged commit ec9408c into dev Sep 25, 2023

katspaugh deleted the cypress-tests-refactor-p3 branch September 25, 2023 07:29

github-actions bot locked and limited conversation to collaborators Sep 25, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Cypress tests refactoring: PO model, safe app tests #2522

Cypress tests refactoring: PO model, safe app tests #2522

mike10ca commented Sep 18, 2023

github-actions bot commented Sep 18, 2023 •

edited

Loading

github-actions bot commented Sep 18, 2023 •

edited

Loading

katspaugh Sep 21, 2023

mike10ca Sep 22, 2023

usame-algan Sep 26, 2023

mike10ca Sep 26, 2023

iamacook Sep 22, 2023

iamacook Sep 22, 2023

iamacook Sep 22, 2023

iamacook Sep 22, 2023

iamacook Sep 22, 2023

iamacook Sep 22, 2023

iamacook Sep 22, 2023

iamacook Sep 22, 2023

	export function lickOnCollapseAllBtn() {
	export function clickOnCollapseAllBtn() {

	const expandallbtnStr = 'Expand all'
	const expandAllBtnStr = 'Expand all'

		@@ -0,0 +1,193 @@
		import * as constants from '../../support/constants'

		const searchappInput = 'input[id="search-by-name"]'

	import * as createtx from '../pages/create_tx.pages'
	import * as createTx from '../pages/create_tx.pages'

		export const proposeEndPoint = '/**/propose'
		export const appsEndPoint = '/**/safe-apps'

	wrapped_ether: 'Wrapped Ether',
	wrappedEther: 'Wrapped Ether',

Cypress tests refactoring: PO model, safe app tests #2522

Cypress tests refactoring: PO model, safe app tests #2522

Conversation

mike10ca commented Sep 18, 2023

What it solves

How this PR fixes it

github-actions bot commented Sep 18, 2023 • edited Loading

Branch preview

github-actions bot commented Sep 18, 2023 • edited Loading

ESLint Summary View Full Report

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

github-actions bot commented Sep 18, 2023 •

edited

Loading

github-actions bot commented Sep 18, 2023 •

edited

Loading