-
Notifications
You must be signed in to change notification settings - Fork 453
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: redesign Load Safe #1405
feat: redesign Load Safe #1405
Conversation
Branch preview✅ Deploy successful! |
ESLint Summary View Full Report
Report generated by eslint-plus-action |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The code looks good, and in my testing, it also works fine.
I don't like calling components Step0, Step1 etc, but it's the same in the creation...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
Correction. I've checked and the ENS autofill name is broken in prod as well. It would be great if that can be fixed here, but is not a blocker to pass this ticket. |
For me it resolves the ENS and autofills it as a placeholder to the name input. I think this is the intended behaviour as it was changed to be a placeholder in #353 The reason why goerlisafe.eth is not resolving is because it needs to be set as a reverse record entry to the safe address |
ESLint Summary View Full Report
Report generated by eslint-plus-action |
I didn't noticed that the name wasn't properly set. Now it works fine |
What it solves
Resolves #964
How this PR fixes it
src/components/load-safe
were copied into the new structure withinsrc/components/new-safe/load
with minor layout adjustments/open
and/load
and their pages/new-safe/create
and/new-safe/load
everywherenew-safe
directoryToDos
OwnerRow
into the parent directorysrc/components/load-safe
How to test it
Screenshots