Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Track safe creation events under the same category #1312

Merged
merged 1 commit into from
Dec 9, 2022

Conversation

usame-algan
Copy link
Member

@usame-algan usame-algan commented Dec 5, 2022

What it solves

Related to #968

How this PR fixes it

  • The vertical tx stepper passes the category parameter so that the creation flow uses the same eventCategory as the new safe creation flow

How to test it

  1. Open the safe with the AB test set to false
  2. Navigate to /welcome
  3. Create a new safe
  4. Observe that the GTM events include eventCategory: create-safe instead of modal

Analytics changes

  • This will track all safe creation events under the same eventCategory

@usame-algan usame-algan requested a review from iamacook December 5, 2022 17:56
@github-actions
Copy link

github-actions bot commented Dec 5, 2022

CLA Assistant Lite All Contributors have signed the CLA.

@github-actions
Copy link

github-actions bot commented Dec 5, 2022

Branch preview

✅ Deploy successful!

https://fix-create-safe-events--webcore.review-web-core.5afe.dev

@github-actions
Copy link

github-actions bot commented Dec 5, 2022

ESLint Summary View Full Report

Annotations are provided inline on the Files Changed tab. You can also see all annotations that were generated on the annotations page.

Type Occurrences Fixable
Errors 0 0
Warnings 0 0
Ignored 0 N/A
  • Result: ✅ success
  • Annotations: 0 total

Report generated by eslint-plus-action

@usame-algan usame-algan changed the title fix: Track safe cretion events under the same category fix: Track safe creation events under the same category Dec 5, 2022
@katspaugh
Copy link
Member

Tested, the categories are correct. ✅

Screenshot 2022-12-09 at 08 07 07

@katspaugh katspaugh merged commit 51239d7 into dev Dec 9, 2022
@katspaugh katspaugh deleted the fix-create-safe-events branch December 9, 2022 07:07
@github-actions github-actions bot locked and limited conversation to collaborators Dec 9, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants