Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Safe cration text changes #1239

Merged
merged 2 commits into from
Nov 24, 2022
Merged

fix: Safe cration text changes #1239

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6c37783
fix: Safe cration text changes
usame-algan Nov 24, 2022
f832e24
fix: Adjust safe indexed message
usame-algan Nov 24, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/components/dashboard/CreationDialog/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,7 +60,7 @@ const CreationDialog = () => {
<HintItem
Icon={HelpCenterIcon}
title="Help center"
description="HHave any questions? Check out our collection of articles."
description="Have any questions? Check out our collection of articles."
/>
</Grid>
<Box display="flex" justifyContent="center">
Expand Down
10 changes: 5 additions & 5 deletions src/components/new-safe/CreateSafe/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ const staticHints: Record<
{ title: string; variant: AlertColor; steps: { title: string; text: string | ReactElement }[] }
> = {
1: {
title: 'Safe Creation',
title: 'Safe creation',
variant: 'info',
steps: [
{
Expand All @@ -47,7 +47,7 @@ const staticHints: Record<
],
},
2: {
title: 'Safe Creation',
title: 'Safe creation',
variant: 'info',
steps: [
{
Expand All @@ -59,7 +59,7 @@ const staticHints: Record<
text: 'You can always change the number of owners and required confirmations in your Safe after creation.',
},
{
title: 'Safe Setup',
title: 'Safe setup',
text: (
<>
Not sure how many owners and confirmations you need for your Safe?
Expand All @@ -82,7 +82,7 @@ const staticHints: Record<
],
},
3: {
title: 'Safe Creation',
title: 'Safe creation',
variant: 'info',
steps: [
{
Expand All @@ -92,7 +92,7 @@ const staticHints: Record<
],
},
4: {
title: 'Safe Usage',
title: 'Safe usage',
variant: 'success',
steps: [
{
Expand Down
6 changes: 3 additions & 3 deletions src/components/new-safe/steps/Step2/useSafeSetupHints.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,20 +12,20 @@ export const useSafeSetupHints = (
// 1/n warning
if (threshold === 1) {
safeSetupWarningSteps.push({
title: `1/${noOwners}`,
title: `1/${noOwners} policy`,
text: 'We recommend using a threshold higher than one to prevent losing access to your Safe in case an owner key is lost or compromised.',
})
}

// n/n warning
if (threshold === noOwners && noOwners > 1) {
safeSetupWarningSteps.push({
title: `${noOwners}/${noOwners}`,
title: `${noOwners}/${noOwners} policy`,
text: 'We recommend using a threshold which is lower than the total number of owners of your Safe in case an owner loses access to their account and needs to be replaced.',
})
}

setHint({ title: 'Safe Setup', variant: 'warning', steps: safeSetupWarningSteps })
setHint({ title: 'Safe setup', variant: 'warning', steps: safeSetupWarningSteps })

// Clear dynamic hints when the step / hook unmounts
return () => {
Expand Down
2 changes: 1 addition & 1 deletion src/components/new-safe/steps/Step4/StatusMessage.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@ const getStep = (status: SafeCreationStatus) => {
}
case SafeCreationStatus.INDEXED:
return {
description: 'Your Safe was successfully indexed!',
description: 'Your Safe is ready!',
instruction: '',
}
case SafeCreationStatus.INDEX_FAILED:
Expand Down