fix: review issues

safe-global · Oct 6, 2023 · d55bc1b · d55bc1b
1 parent 5bb3cdc
commit d55bc1b
Show file tree

Hide file tree

Showing 3 changed files with 33 additions and 23 deletions.
diff --git a/src/components/welcome/NewSafe.tsx b/src/components/welcome/NewSafe.tsx
@@ -12,16 +12,27 @@ import { selectTotalAdded } from '@/store/addedSafesSlice'
 
 import drawerCSS from '@/components/sidebar/Sidebar/styles.module.css'
 
+const BulletListItem = ({ text }: { text: string }) => (
+  <li>
+    <SvgIcon className={css.checkIcon} component={CheckFilled} inheritViewBox />
+    <Typography color="static.main" fontWeight={700}>
+      {text}
+    </Typography>
+  </li>
+)
+
 const NewSafe = () => {
   const addedSafes = useAppSelector(selectTotalAdded)
 
   const [showSidebar, setShowSidebar] = useState(false)
 
+  const closeSidebar = () => setShowSidebar(false)
+
   return (
     <>
-      <Drawer variant="temporary" anchor="left" open={showSidebar} onClose={() => setShowSidebar(false)}>
+      <Drawer variant="temporary" anchor="left" open={showSidebar} onClose={closeSidebar}>
         <div className={drawerCSS.drawer}>
-          <SafeList closeDrawer={() => setShowSidebar(false)} />
+          <SafeList closeDrawer={closeSidebar} />
 
           <div className={drawerCSS.dataWidget}>
             <DataWidget />
@@ -62,26 +73,11 @@ const NewSafe = () => {
               The most trusted decentralized custody protocol and collective asset management platform.
             </Typography>
 
-            <Grid container spacing={2} mb="auto">
-              <Grid item xs={12} display="flex" flexDirection="row" gap={1} alignItems="center">
-                <SvgIcon className={css.checkIcon} component={CheckFilled} inheritViewBox />
-                <Typography color="static.main" fontWeight={700}>
-                  Stealth security with multiple owners
-                </Typography>
-              </Grid>
-              <Grid item xs={12} display="flex" flexDirection="row" gap={1} alignItems="center">
-                <SvgIcon className={css.checkIcon} component={CheckFilled} inheritViewBox />
-                <Typography color="static.main" fontWeight={700}>
-                  Make it yours with modules and guards
-                </Typography>
-              </Grid>
-              <Grid item xs={12} display="flex" flexDirection="row" gap={1} alignItems="center">
-                <SvgIcon className={css.checkIcon} component={CheckFilled} inheritViewBox />
-                <Typography color="static.main" fontWeight={700}>
-                  Access 130+ ecosystem apps
-                </Typography>
-              </Grid>
-            </Grid>
+            <ul className={css.bulletList}>
+              <BulletListItem text="Stealth security with multiple owners" />
+              <BulletListItem text="Make it yours with modules and guards" />
+              <BulletListItem text="Access 130+ ecosystem apps" />
+            </ul>
           </div>
         </Grid>
       </Grid>

diff --git a/src/components/welcome/WelcomeLogin/styles.module.css b/src/components/welcome/WelcomeLogin/styles.module.css
@@ -5,6 +5,7 @@
   border-radius: 6px;
   justify-content: center;
   align-items: center;
+  padding: var(--space-2);
 }
 
 .loginContent {

diff --git a/src/components/welcome/styles.module.css b/src/components/welcome/styles.module.css
@@ -25,12 +25,25 @@
   width: 100%;
 }
 
+.bulletList {
+  list-style: none;
+  margin-bottom: auto;
+}
+
+.bulletList li {
+  display: flex;
+  flex-direction: row;
+  gap: var(--space-1);
+  align-items: center;
+  margin-bottom: var(--space-2);
+}
+
 .content {
   background: linear-gradient(-90deg, #10ff84, #5fddff);
   background-size: 200% 200%;
   animation: gradient 15s ease infinite;
   border-radius: 6px;
-  padding: var(--space-3) var(--space-3);
+  padding: var(--space-3);
   display: flex;
   flex-direction: column;
   justify-content: center;