Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a table for not valid tokens #2326

Merged
merged 1 commit into from
Nov 18, 2024
Merged

Add a table for not valid tokens #2326

merged 1 commit into from
Nov 18, 2024

Conversation

Uxio0
Copy link
Member

@Uxio0 Uxio0 commented Nov 12, 2024 •
edited
Loading

@Uxio0 Uxio0 requested a review from a team as a code owner November 12, 2024 13:47
@Uxio0
Copy link
Member Author

Uxio0 commented Nov 15, 2024

Thanks @falvaradorodriguez . I would like @moisses89 review here too as he was working in the balances stuff not so long ago 😉

moisses89
moisses89 approved these changes Nov 18, 2024
View reviewed changes
Copy link
Member

@moisses89 moisses89 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!
Just a minimal comment, do you think that makes sense add something like, why is not a token address included in the Safe balances? to the FAQ?

@Uxio0
Add a table for not valid tokens
b68639d 
- Not valid tokens are retrieved again and again after cache expires
- Add a simple list of not valid tokens so RPC call is not required
- Closes #2283
@Uxio0
Copy link
Member Author

Uxio0 commented Nov 18, 2024

Looks good to me! Just a minimal comment, do you think that makes sense add something like, why is not a token address included in the Safe balances? to the FAQ?

Done!

@Uxio0 Uxio0 merged commit f1021a7 into main Nov 18, 2024
5 checks passed
@Uxio0 Uxio0 deleted the add-failed-erc20 branch November 18, 2024 13:26
@github-actions github-actions bot locked and limited conversation to collaborators Nov 18, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@moisses89 moisses89 moisses89 approved these changes

@falvaradorodriguez falvaradorodriguez falvaradorodriguez approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Balances really slow for one Safe in Base network
3 participants
@Uxio0 @falvaradorodriguez @moisses89