Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Denormalize InternalTxDecoded #2304

Merged
merged 1 commit into from
Nov 4, 2024
Merged

Denormalize InternalTxDecoded #2304

merged 1 commit into from
Nov 4, 2024

Conversation

Uxio0
Copy link
Member

@Uxio0 Uxio0 commented Nov 4, 2024 •
edited
Loading

  • Add safe field so it can be indexed propertly

This PR will speed up transaction processing speed:

  • Query to return all the pending Safes to process should be instant now, as it only needs to fetch a index
  • Query to get all the pending transactions pending to process for a Safe should be very fast. It still needs a JOIN, but before that the index will be used

@Uxio0 Uxio0 requested a review from a team as a code owner November 4, 2024 13:50
@Uxio0
Denormalize InternalTxDecoded
b764ae9 
- Add `safe` field so it can be indexed propertly
- This PR will speed up transaction processing speed
@Uxio0 Uxio0 force-pushed the denormalize-internaltx-decoded branch from 84b73b4 to b764ae9 Compare November 4, 2024 13:59
@Uxio0 Uxio0 merged commit 6bbe647 into main Nov 4, 2024
5 checks passed
@Uxio0 Uxio0 deleted the denormalize-internaltx-decoded branch November 4, 2024 15:04
@github-actions github-actions bot locked and limited conversation to collaborators Nov 4, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@moisses89 moisses89 moisses89 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Uxio0 @moisses89