Add support for delegates to delete transactions proposed by themselves #2294
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
falvaradorodriguez
commented
Oct 29, 2024
•
falvaradorodriguez
commented
- Closes Allow Proposal Delete from Delegate that created it #2284
- Delegate users can only delete transactions proposed by themselves.
- Delegate users must still be valid at the time of deletion.
Uxio0
requested changes
Oct 30, 2024
| if safe_signature.owner == proposer: | ||
| return attrs | ||
| if ( | ||
| multisig_tx.proposed_by_delegate | ||
| and safe_signature.owner == multisig_tx.proposed_by_delegate |
There was a problem hiding this comment.
IIRC safe_signature.owner involves computation. If you are using in multiple places please assign it to a variable first
There was a problem hiding this comment.
Makes sense. Fixed here
Co-authored-by: Uxío <[email protected]>
Co-authored-by: Uxío <[email protected]>
falvaradorodriguez
force-pushed
the
allow_delegates_to_delete_proposed_transactions
branch
from
3b80d15 to
11aae70
Compare
Uxio0
approved these changes
Oct 30, 2024
falvaradorodriguez
deleted the
allow_delegates_to_delete_proposed_transactions
branch
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.