Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to OpenApi3 #2280

Merged
merged 10 commits into from
Nov 7, 2024
Merged

Update to OpenApi3 #2280

merged 10 commits into from
Nov 7, 2024

Conversation

moisses89
Copy link
Member

Closes #2268

@moisses89 moisses89 marked this pull request as ready for review October 30, 2024 12:54
@moisses89 moisses89 requested a review from a team as a code owner October 30, 2024 12:54
@Uxio0
Copy link
Member

Uxio0 commented Oct 30, 2024

Approved, but for this PR the real approve will come from @JagoFigueroa checking the actual render

@moisses89
Copy link
Member Author

Sharing with @JagoFigueroa for testing the openApi specification.
Safe Transaction Service v3.txt

to be validated with https://editor.swagger.io/ tool.

*Disable sorting parameters
*Add pagination filter to some missing endpoints
*Add favicon icon
@JagoFigueroa
Copy link

Gave the swagger a couple of runs and should be looking bien rocoso after the latest changes 😄 Happy to give it a final 👀 before merging it or once merged too!

@moisses89
Copy link
Member Author

Gave the swagger a couple of runs and should be looking bien rocoso after the latest changes 😄 Happy to give it a final 👀 before merging it or once merged too!

Could you do a last review to this new schema?
Safe Transaction Servicev3.1.txt

@JagoFigueroa
Copy link

Looking perfecto now! 🚀

@moisses89 moisses89 merged commit db6e20c into main Nov 7, 2024
5 checks passed
@moisses89 moisses89 deleted the update_openapi branch November 7, 2024 13:18
@github-actions github-actions bot locked and limited conversation to collaborators Nov 7, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update API docs to use OAS 3
3 participants