Balances really slow for one Safe in Base network #2283
Assignees
Labels
bug
Something isn't working
Comments
Uxio0
added a commit
that referenced
this issue
Nov 12, 2024
- Not valid tokens are retrieved again and again after cache expires - Add a simple list of not valid tokens so RPC call is not required - Closes #2283
Uxio0
added a commit
that referenced
this issue
Nov 18, 2024
- Not valid tokens are retrieved again and again after cache expires - Add a simple list of not valid tokens so RPC call is not required - Closes #2283
Uxio0
added a commit
that referenced
this issue
Nov 18, 2024
- Not valid tokens are retrieved again and again after cache expires - Add a simple list of not valid tokens so RPC call is not required - Closes #2283
|
Tested and verified after our latest deployment. Cheers! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
and others
For https://safe-transaction-base.safe.global/api/v1/safes/0x32e52896663De88a65c2D94917b006404415A89f/balances/ is really slow (until cache is warm).
After debugging it, we realised is not an RPC or database optimization issue.
The issue is that for a lot of tokens they don't exist in the database so we try to recover them from blockchain, with no luck as they don't hold usual ERC20 information like
nameorsymbol: https://basescan.org/address/0x20b09dCb0Ca884448acE9DDB10D7851Bfe26C261#readContractMethod causing the bottleneck: https://github.com/safe-global/safe-transaction-service/blob/main/safe_transaction_service/history/services/balance_service.py#L293
The text was updated successfully, but these errors were encountered: