Fix race conditions when inserting tokens on TokenNotValid

- Add admin page for `TokenNotValid`
safe-global · Nov 19, 2024 · 06a66f6 · 06a66f6
1 parent 94e5ee3
commit 06a66f6
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 3 deletions.
diff --git a/safe_transaction_service/tokens/admin.py b/safe_transaction_service/tokens/admin.py
@@ -5,7 +5,7 @@
     HasLogoFilterAdmin,
 )
 
-from .models import Token, TokenList
+from .models import Token, TokenList, TokenNotValid
 
 
 @admin.register(Token)
@@ -34,3 +34,10 @@ class TokenListAdmin(admin.ModelAdmin):
     )
     ordering = ("pk",)
     search_fields = ["url", "description"]
+
+
+@admin.register(TokenNotValid)
+class TokenNotValidAdmin(AdvancedAdminSearchMixin, admin.ModelAdmin):
+    list_display = ("address",)
+    ordering = ("address",)
+    search_fields = ["==address"]
diff --git a/safe_transaction_service/tokens/models.py b/safe_transaction_service/tokens/models.py
@@ -122,15 +122,15 @@ def create_from_blockchain(
                 logger.debug(
                     "Cannot find anything on blockchain for token=%s", token_address
                 )
-                TokenNotValid.objects.create(address=token_address)
+                TokenNotValid.objects.get_or_create(address=token_address)
                 return None
 
         # Ignore tokens with empty name or symbol
         if not erc_info.name or not erc_info.symbol:
             logger.warning(
                 "Token with address=%s has not name or symbol", token_address
             )
-            TokenNotValid.objects.create(address=token_address)
+            TokenNotValid.objects.get_or_create(address=token_address)
             return None
 
         name_and_symbol: list[str] = []