Skip to content
This repository has been archived by the owner on Dec 4, 2024. It is now read-only.

There is no agreement in the community regarding the RPC method for batched transactions #1

Open
sche opened this issue Nov 19, 2021 · 4 comments

Comments

@sche
Copy link

sche commented Nov 19, 2021

What is the problem?

Batch transactions are becoming more popular as more dapps start supporting them. We believe that smart contracts wallets that can organically support batch transactions will be more adopted with time. But currently, different smart contract wallets don't have a shared standard for batching transactions. For example, we implemented the "gs_multi_send" RPC method, but Argent uses the "wc_multicall" method.

Why is it relevant?

If we support one or several batching RPC methods, we need to work on a shared vision across the community.

How can we track the problem?

We need to ensure that the most adopted smart contract wallets with batching functionality support the same RPC method.

Links

Reference discussion: safe-global/safe-apps-sdk#245

@mmv08
Copy link
Member

mmv08 commented Nov 25, 2021

I've put a doc for wallet_batchTransactions RPC method. You can find it here: https://hackmd.io/@Ern58-qRQOOwhMHuP25aPg/ryQPojsuK

I'd appreciate your feedback before sharing it with other projects

@dasanra dasanra added the apps label Nov 25, 2021
@mmv08
Copy link
Member

mmv08 commented Nov 29, 2021

@DmitryBespalov, I've replied to your comments in the doc, just dropping a mention here because HackMD didn't send me any notifications about comments

@mmv08
Copy link
Member

mmv08 commented Dec 3, 2021

I would appreciate your feedback on the second round of wallet_batchTransaction RPC proposal, this time it is EOA "compatible", and the transaction types are exactly the same as in eth_sendTransaction. https://hackmd.io/HFHohGDbRSGgUFI2rk22bA?view

EDIT: Argent team said they'd be happy to support this too.

@sche sche changed the title There is not standard in the community regarding RPC method for batched transactions There is no standard in the community regarding RPC method for batched transactions Dec 23, 2021
@sche sche changed the title There is no standard in the community regarding RPC method for batched transactions There is no agreement in the community regarding the RPC method for batched transactions Jan 7, 2022
@sche sche removed the draft label Jan 7, 2022
@mmv08
Copy link
Member

mmv08 commented Feb 28, 2022

Richard Moore (author of ethers.js) shared his feedback: https://notes.ethereum.org/J0_Qs3dfQtGVmVTcb-rqUg

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

4 participants