-
Notifications
You must be signed in to change notification settings - Fork 128
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Research: Can/which SDK packages can support batch transactions with minimal development #245
Comments
The biggest obstacle for broader batch transactions support is that only smart contract wallets support them. So it's tough to make a one-stop solution that would use batch transactions for SC wallets and fall back to regular transactions for an EOA wallet. dApp developers need to implement conditional logic for sending txs 1-by-1 or as a batch depending on a wallet. The only possible way to batch transactions with a Safe is to use the I think the best way to go with is a solution as wallet-agnostic as possible. I believe that SC wallets will eventually overtake EOAs and that there will be some standards for batching transactions in the future, and our solution can serve as a base. My proposed solution is to support Argent's cc @rmeissner @sche |
Thanks @mikheevm |
It turns out that argent's multicall is not an RPC method, it's a fake ABI that is then mapped to a different method on a smart contract on the app side:
Personally, not a big fan of this approach. I've asked them if they're interested in collaborating in a shared RPC method. |
I shared a proposal doc in this issue for team review |
I would appreciate your feedback on the second round of wallet_batchTransaction RPC proposal, this time it is EOA “compatible”, and the transaction types are exactly the same as in eth_sendTransaction. https://hackmd.io/HFHohGDbRSGgUFI2rk22bA?view |
Update: Argent team said they would be happy to support this too. |
Background:
1inch has introduced batch transactions for their Safe App. The experience is glorious.
To my knowledge, it is the only "Dapp as a Safe App" that does this. We know from looking at data that most common transactions come from Defi protocols:
Problem:
1inch did the integration via the javascript SDK, it comes with more flexibility than say the web3 modules or onboard.js packages but requires more understanding and work to intergrate.
What can we do?
The purpose of this ticket is to answer the following questions:
What should the research unlock?
If we know that it is possible to facilitate batch transactions via existing web3 wallet libraries, then we can push it as a default standard. If it can't be done, then we need to incentivize and encourage dapp developers through promotion and placement in the Safe Apps UI.
The text was updated successfully, but these errors were encountered: