Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GH-3400 transaction creation with ledger and keystone #3401

Merged
merged 1 commit into from
Apr 8, 2024

Conversation

DmitryBespalov
Copy link
Contributor

Handles #3400

Changes proposed in this pull request:

  • Fix for the ledger and keystone signature format sent to the api.

Copy link

codecov bot commented Apr 8, 2024

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 8.27%. Comparing base (c50a242) to head (1eaf6a5).
Report is 1 commits behind head on main.

Files Patch % Lines
Multisig/Logic/Ledger/LedgerController.swift 0.00% 1 Missing ⚠️
...Management/KeystoneOwnerKey/KeystoneSignFlow.swift 0.00% 1 Missing ⚠️
Additional details and impacted files
@@          Coverage Diff          @@
##            main   #3401   +/-   ##
=====================================
  Coverage   8.27%   8.27%           
=====================================
  Files        789     789           
  Lines      44082   44082           
=====================================
  Hits        3647    3647           
  Misses     40435   40435           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@DmitryBespalov DmitryBespalov merged commit b7bdc71 into main Apr 8, 2024
4 of 5 checks passed
@DmitryBespalov DmitryBespalov deleted the GH-3400/fix-hardware-wallet-signatures branch April 8, 2024 10:07
@github-actions github-actions bot locked and limited conversation to collaborators Apr 8, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant