GH-3435 move string to a property

safe-global · Jul 2, 2024 · 15b424a · 15b424a
1 parent 79e38df
commit 15b424a
Show file tree

Hide file tree

Showing 4 changed files with 9 additions and 8 deletions.
diff --git a/Multisig/Data/Services/Safe Client Gateway Service/SCGModels.swift b/Multisig/Data/Services/Safe Client Gateway Service/SCGModels.swift
@@ -423,6 +423,7 @@ extension SCGModels {
         struct TwapOrder: Codable {
             var kind: String
             var status: String
+            var displayName: String { "Twap order" }
         }
     }
 

diff --git a/Multisig/UI/Transaction/TransactionDetailsViewController/TransactionDetailCellBuilder.swift b/Multisig/UI/Transaction/TransactionDetailsViewController/TransactionDetailCellBuilder.swift
@@ -380,8 +380,8 @@ class TransactionDetailCellBuilder {
         case .swapTransfer(let orderInfo):
             text(orderInfo.swapTransferDisplayName, title: "Contract Interaction", expandableTitle: nil, copyText: nil)
             externalURL(text: "Order details", url: orderInfo.explorerUrl)
-        case .twapOrder(_):
-            text("Twap order", title: "Contract Interaction", expandableTitle: nil, copyText: nil)
+        case .twapOrder(let order):
+            text(order.displayName, title: "Contract Interaction", expandableTitle: nil, copyText: nil)
         case .creation(_):
             // ignore
             fallthrough
@@ -672,8 +672,8 @@ class TransactionDetailCellBuilder {
         case .swapTransfer(let order):
             type = order.swapTransferDisplayName
             icon = UIImage(named: "ico-custom-tx")
-        case .twapOrder(_):
-            type = "Twap order"
+        case .twapOrder(let order):
+            type = order.displayName
             icon = UIImage(named: "ico-custom-tx")
         case .unknown:
             type = "Unknown operation"

diff --git a/Multisig/UI/Transaction/TransactionListViewController/TransactionListViewController.swift b/Multisig/UI/Transaction/TransactionListViewController/TransactionListViewController.swift
@@ -371,9 +371,9 @@ class TransactionListViewController: LoadableViewController, UITableViewDelegate
         case .swapTransfer(let order):
             image = UIImage(named: "ico-custom-tx")
             title = order.swapTransferDisplayName
-        case .twapOrder(_):
+        case .twapOrder(let order):
             image = UIImage(named: "ico-custom-tx")
-            title = "Twap order"
+            title = order.displayName
         case .unknown:
             image = UIImage(named: "ico-custom-tx")
             title = "Unknown operation"

diff --git a/...onnect/Server/Safes/Incoming Transaction/WCIncomingTransactionRequestViewController.swift b/...onnect/Server/Safes/Incoming Transaction/WCIncomingTransactionRequestViewController.swift
@@ -143,9 +143,9 @@ class WCIncomingTransactionRequestViewController: ReviewSafeTransactionViewContr
         case .swapTransfer(let order):
             imageName = "ico-custom-tx"
             name = order.swapTransferDisplayName
-        case .twapOrder(_):
+        case .twapOrder(let order):
             imageName = "ico-custom-tx"
-            name = "Twap transfer"
+            name = order.displayName
         case .unknown:
             imageName = "ico-custom-tx"
             name = "Unknown operation"