feat(wallet): Wallet faq #486
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Branch preview✅ Deployed successfully in branch deployment: |
iamacook
reviewed
Nov 4, 2024
src/content/wallet.json
Outdated
| "title": "FAQ", | ||
| "items": [ | ||
| { | ||
| "title": "What is a Safe smart account?", |
There was a problem hiding this comment.
Suggested change
| "title": "What is a Safe smart account?", | |
| "title": "What is a Safe Smart Account?", |
There was a problem hiding this comment.
Applied in the CMS entry. You can verify in the PR deployment.
src/content/wallet.json
Outdated
| }, | ||
| { | ||
| "title": "What networks are supported by Safe{Wallet}?", | ||
| "text": "Safe{Wallet} supports a wide range of blockchain networks, allowing you to manage your crypto assets across multiple platforms. The supported networks include Ethereum, Gnosis Chain, Polygon, Polygon zkEVM, BNB Chain, Arbitrum, Optimism, Base, Linea, zkSync Era, Scroll, X Layer, Celo, Avalanche, and Aurora. You can easily select the appropriate network when setting up your Safe Smart Account or when managing your funds within the Safe{Wallet} platform." |
There was a problem hiding this comment.
What do you think about populating this list from the Config Service?
There was a problem hiding this comment.
I would rather find a solution through the CMS. Let me iterate on it and will ping you again to review.
src/components/common/FAQ/index.tsx
Outdated
Comment on lines
51
to
53
| onClick={() => { | ||
| !expanded | ||
| }} |
There was a problem hiding this comment.
Suggested change
| onClick={() => { | |
| !expanded | |
| }} |
src/components/common/FAQ/index.tsx
Outdated
Comment on lines
43
to
44
| expanded={expanded} | ||
| onChange={handleChange} |
There was a problem hiding this comment.
Why is this being controlled? The Accordion doesn't need to be.
There was a problem hiding this comment.
It was the way I found to setOpenMap and control which accordions are open by index.
iamacook
approved these changes
Nov 5, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What it solves
Implements the generic FAQ section with content imported from the JSON file. Similar to https://github.com/safe-global/safe-homepage/tree/main/src/components/commonCMS/Faq
Figma
https://www.figma.com/design/qtXXlwdslAze6yNbLLzIRa/Website-redesign-2.0?node-id=15367-15363&node-type=frame&t=qN9WsCrCOsfBan3X-0