Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: allow per-page layout #477

Merged
merged 2 commits into from
Oct 16, 2024
Merged

refactor: allow per-page layout #477

merged 2 commits into from
Oct 16, 2024

Conversation

DiogoSoaress
Copy link
Member

@DiogoSoaress DiogoSoaress commented Oct 15, 2024 •
edited
Loading

What it solves

  • Enables defining a custom page layout while defaulting to a common one
  • Strengthens getStaticProps typing
  • Move Contentful Entry types to a common types file

@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 15, 2024 •
edited
Loading

Branch preview

✅ Deployed successfully in branch deployment:

https://refactor_get_layout--homepage.review.5afe.dev

@DiogoSoaress DiogoSoaress requested a review from iamacook October 15, 2024 15:54
@DiogoSoaress DiogoSoaress merged commit 291b1a1 into main Oct 16, 2024
4 checks passed
@DiogoSoaress DiogoSoaress deleted the refactor-get-layout branch October 16, 2024 15:25
@github-actions github-actions bot locked and limited conversation to collaborators Oct 16, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@iamacook iamacook iamacook approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@DiogoSoaress @iamacook