feat: banner for SafeAuth #254
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ESLint Summary View Full Report
Report generated by eslint-plus-action |
Branch preview✅ Deployed to dev: |
DiogoSoaress
commented
Dec 4, 2023
Comment on lines
+26
to
+27
| const bgImage = isSmallScreen ? backgroundImage.sm : backgroundImage.md | ||
| const imageSrc = image ? (isSmallScreen ? image.sm : image.md) : undefined |
There was a problem hiding this comment.
I am not sure this will be the closest implementation to what we'll have in the CMS. Open to hear other suggestions.
There was a problem hiding this comment.
katspaugh
approved these changes
Dec 5, 2023
katspaugh
reviewed
Dec 5, 2023
| e.preventDefault() | ||
|
|
||
| scrollToElement('#masthead', 200) | ||
| scrollToElement(target, 200) |
There was a problem hiding this comment.
Btw, the offset in this function can be replaced with CSS.
* {
scroll-margin-top: 60px; // header height
}
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What it solves
Modifies the Core page to show a banner allusive to the SafeAuth partnership
Figma
https://www.figma.com/file/gxyAh1UOL6TXG1N5PWYLIB/Internal-Graphics?type=design&node-id=4317-257&mode=design&t=IKGFvK1GoeiU5V7S-4