feat: Governance page #243
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ESLint Summary View Full Report
Report generated by eslint-plus-action |
Branch preview✅ Deployed to dev: |
katspaugh
reviewed
Oct 26, 2023
| "contribution": "Wrote tutorials on gnosis safe for DAOs in English and Chinese.", | ||
| "twitter": "https://twitter.com/0xAA_Science" | ||
| } | ||
| ] |
There was a problem hiding this comment.
This is not a component, right? It's part of the content.
| @@ -31,8 +31,7 @@ const navItems: NavItemType[] = [ | |||
| }, | |||
| { | |||
| label: 'Governance', | |||
| href: GOVERNANCE_LINK, | |||
| external: true, | |||
| href: AppRoutes.governance, | |||
There was a problem hiding this comment.
You might want to extract these links to a JSON as well at some point.
There was a problem hiding this comment.
The links we have in the constants file?
There was a problem hiding this comment.
I mean the whole configuration of the header. What links and their names to display in the header.
There was a problem hiding this comment.
Good suggestion! I've moved that data to a content file as well.
katspaugh
approved these changes
Oct 26, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What it solves
Implementation of the Governance page according to design.
Obs
A list of delegates was provided by Andre, meaning we have no dynamic fetch in this iteration as the criteria to rank top delegates is still tbd.
Removed a bunch of unused assets. Mostly images that were replaced by parallax elements and were unused.
Refactors (tiny)
components/Walletto thecomponents/commonfoldercomponents/Hometo thecomponents/commonfolder