Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add 4337 bundler API client #776

Merged
merged 7 commits into from
Feb 20, 2024
Merged

Add 4337 bundler API client #776

merged 7 commits into from
Feb 20, 2024

Conversation

Uxio0
Copy link
Member

@Uxio0 Uxio0 commented Feb 12, 2024

@Uxio0 Uxio0 requested a review from a team as a code owner February 12, 2024 17:47
@Uxio0 Uxio0 requested review from fmrsabino, moisses89 and iamacook and removed request for a team February 12, 2024 17:47
@Uxio0 Uxio0 self-assigned this Feb 12, 2024
moisses89
moisses89 requested changes Feb 19, 2024
View reviewed changes
Copy link
Member

@moisses89 moisses89 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added some required changes but also some suggestions.
Nice work :)

gnosis/eth/account_abstraction/bundler_client.py Show resolved Hide resolved
gnosis/eth/account_abstraction/bundler_client.py Show resolved Hide resolved
gnosis/eth/account_abstraction/bundler_client.py Show resolved Hide resolved
gnosis/eth/account_abstraction/user_operation.py Outdated Show resolved Hide resolved
gnosis/eth/tests/aa/__init__.py Outdated Show resolved Hide resolved
gnosis/safe/tests/aa/__init__.py Outdated Show resolved Hide resolved
gnosis/safe/account_abstraction/safe_operation.py Show resolved Hide resolved
gnosis/eth/account_abstraction/user_operation.py Show resolved Hide resolved
gnosis/safe/account_abstraction/safe_operation.py Show resolved Hide resolved
@Uxio0 Uxio0 merged commit a6ebe6d into master Feb 20, 2024
7 checks passed
@Uxio0 Uxio0 deleted the add-bundler-client branch February 20, 2024 12:04
@github-actions github-actions bot locked and limited conversation to collaborators Feb 20, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@moisses89 moisses89 moisses89 approved these changes

@fmrsabino fmrsabino Awaiting requested review from fmrsabino fmrsabino was automatically assigned from safe-global/safe-services

@iamacook iamacook Awaiting requested review from iamacook iamacook was automatically assigned from safe-global/safe-services

Assignees

@Uxio0 Uxio0

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Create client for EIP4337 Bundler APIs
2 participants
@Uxio0 @moisses89