Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add BASE Sepolia Safe addresses #747

Merged
merged 1 commit into from
Jan 23, 2024
Merged

Add BASE Sepolia Safe addresses #747

merged 1 commit into from
Jan 23, 2024

Conversation

Uxio0
Copy link
Member

@Uxio0 Uxio0 commented Jan 22, 2024

No description provided.

@Uxio0 Uxio0 requested a review from a team as a code owner January 22, 2024 15:20
@Uxio0 Uxio0 requested review from fmrsabino, moisses89 and hectorgomezv and removed request for a team January 22, 2024 15:20
@Uxio0 Uxio0 force-pushed the add-base-sepolia branch 7 times, most recently from c1a596d to e7fe853 Compare January 23, 2024 13:57
@@ -27,7 +27,6 @@ class KyberOracle(PriceOracle):
EthereumNetwork.MAINNET: "0x9AAb3f75489902f3a48495025729a0AF77d4b11e",
EthereumNetwork.RINKEBY: "0x0d5371e5EE23dec7DF251A8957279629aa79E9C5",
EthereumNetwork.ROPSTEN: "0xd719c34261e099Fdb33030ac8909d5788D3039C4",
EthereumNetwork.KOVAN: "0xc153eeAD19e0DBbDb3462Dcc2B703cC6D738A37c",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why KOVAN is removed?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's no Kovan testnet anymore

Copy link
Member

@moisses89 moisses89 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just a comment.

@Uxio0 Uxio0 merged commit 4672097 into master Jan 23, 2024
6 checks passed
@Uxio0 Uxio0 deleted the add-base-sepolia branch January 23, 2024 14:51
@github-actions github-actions bot locked and limited conversation to collaborators Jan 23, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants