Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Fantom Opera and Fantom Testnet support #609

Merged
merged 1 commit into from
Oct 6, 2023

Conversation

jenikd
Copy link
Contributor

@jenikd jenikd commented Aug 14, 2023

Adding support for Fantom Opera and Fantom Testnet networks and their Etherscan compatible client called FTMScan

Reference:
safe-global/safe-deployments#243

@jenikd jenikd requested a review from a team as a code owner August 14, 2023 13:53
@jenikd jenikd requested review from fmrsabino, moisses89 and iamacook and removed request for a team August 14, 2023 13:53
@github-actions
Copy link
Contributor

github-actions bot commented Aug 14, 2023

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

@jenikd
Copy link
Contributor Author

jenikd commented Aug 14, 2023

I can not read CLA as the page was not found and I can't find it anywhere on safe.global

Screenshot 2023-08-14 at 15 59 00

@moisses89
Copy link
Member

CLA Assistant Lite bot: Thank you for your submission, we really appreciate it. Like many open-source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution. You can sign the CLA by just posting a Pull Request Comment same as the below format.

I have read the CLA Document and I hereby sign the CLA

You can retrigger this bot by commenting recheck in this Pull Request

Fixing it here, thanks for the heads up :)
#610

@jenikd
Copy link
Contributor Author

jenikd commented Aug 21, 2023

I have read the CLA Document and I hereby sign the CLA

gnosis/safe/addresses.py Outdated Show resolved Hide resolved
@moisses89
Copy link
Member

@HonzaDajc I think is going to be faster if you remove the 1.2.0 addresses here also because this was not still approved, safe-global/safe-deployments#243

@jenikd
Copy link
Contributor Author

jenikd commented Sep 14, 2023

@HonzaDajc I think is going to be faster if you remove the 1.2.0 addresses here also because this was not still approved, safe-global/safe-deployments#243

Ok, I removed v1.2.0 contracts from addresses

@Uxio0
Copy link
Member

Uxio0 commented Oct 6, 2023

Could you rebase so we can merge?

@jenikd
Copy link
Contributor Author

jenikd commented Oct 6, 2023

Hi @Uxio0, I did rebase to current master branch so it can be merged now

@Uxio0 Uxio0 merged commit c2004de into safe-global:master Oct 6, 2023
7 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Oct 6, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants