Apply suggestions from code review

Co-authored-by: Uxío <[email protected]>
safe-global · Sep 4, 2023 · 9deb54c · 9deb54c
1 parent 2811ded
commit 9deb54c
Show file tree

Hide file tree

Showing 3 changed files with 2 additions and 4 deletions.
diff --git a/gnosis/eth/contract_common.py b/gnosis/eth/contract_common.py
@@ -17,7 +17,7 @@ def deploy_contract(
         ethereum_client: EthereumClient,
         deployer_account: LocalAccount,
         contract: Contract,
-    ):
+    ) -> EthereumTxSent:
         tx = contract.constructor().build_transaction(
             {"from": deployer_account.address}
         )

diff --git a/gnosis/safe/proxy_factory.py b/gnosis/safe/proxy_factory.py
@@ -71,7 +71,6 @@ def deploy_proxy_contract(
             master_copy, initializer
         )
 
-        # Auto estimation of gas does not work. We use a little more gas just in case (gas_increment)
         return self.deploy_contract_with_deploy_function(
             self.ethereum_client, deployer_account, create_proxy_fn, gas, gas_price
         )
@@ -103,7 +102,6 @@ def deploy_proxy_contract_with_nonce(
             master_copy, initializer, salt_nonce
         )
 
-        # Auto estimation of gas does not work. We use a little more gas just in case (gas_increment)
         return self.deploy_contract_with_deploy_function(
             self.ethereum_client,
             deployer_account,

diff --git a/gnosis/safe/safe.py b/gnosis/safe/safe.py
@@ -78,7 +78,7 @@ class SafeInfo:
 
 class SafeCommon(ContractCommon):
     """
-    Class to manage a Safe
+    Collection of methods and utilies to handle a Safe
     """
 
     # keccak256("fallback_manager.handler.address")