Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add deploymentType #1032

Merged
merged 6 commits into from
Nov 8, 2024
Merged

feat: Add deploymentType #1032

merged 6 commits into from
Nov 8, 2024

Conversation

yagopv
Copy link
Member

@yagopv yagopv commented Oct 31, 2024 •
edited
Loading

What it solves

  • Adding the deploymentType prop in all the kits
  • Added safeVersion as deployment option in the sdk-starter-kit
  • Use canonical as default in the sdk-starter-kit and fallback to choose the first deployment in the list
  • Add txServiceUrl config option to sdk-starter-kit for chains without the service

@yagopv yagopv linked an issue Oct 31, 2024 that may be closed by this pull request
Enable 4337 configuration safe-global/safe-react-hooks#23
Closed
@coveralls
Copy link

coveralls commented Oct 31, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 11742117631

Details

  • 5 of 13 (38.46%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.7%) to 75.515%
Changes Missing Coverage Covered Lines Changed/Added Lines %
packages/sdk-starter-kit/src/index.ts 4 12 33.33%
Totals Coverage Status
Change from base Build 11683361725: -0.7%
Covered Lines: 786
Relevant Lines: 970
💛 - Coveralls

@yagopv yagopv linked an issue Oct 31, 2024 that may be closed by this pull request
Add deploymentType property to the missing kits #1025
Closed
This was unlinked from issues Oct 31, 2024
Add deploymentType property to the missing kits #1025
Closed
Enable 4337 configuration safe-global/safe-react-hooks#23
Closed
@yagopv yagopv linked an issue Nov 7, 2024 that may be closed by this pull request
Add deploymentType property to the missing kits #1025
Closed
@yagopv yagopv marked this pull request as ready for review November 7, 2024 08:44
@yagopv yagopv requested review from DaniSomoza and dasanra November 7, 2024 08:47
@yagopv yagopv changed the title feat: Add deploymentType feat: Add deploymentType Nov 7, 2024
@yagopv yagopv changed the title feat: Add deploymentType feat: Add deploymentType Nov 7, 2024
@yagopv yagopv merged commit 32b408b into development Nov 8, 2024
19 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Nov 8, 2024
@yagopv yagopv deleted the feat/add-deploymentType-to-kits branch November 8, 2024 12:44
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@dasanra dasanra dasanra approved these changes

@DaniSomoza DaniSomoza Awaiting requested review from DaniSomoza

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add deploymentType property to the missing kits
3 participants
@yagopv @coveralls @dasanra