minor change for camlp5 8.03.00 compat #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This breaks compat with previous versions of Camlp5 OCaml 5.2.0 supports raw identifiers, e.g. "\begin". The Camlp5 pretty-printer needs to know which "identifier-like" strings are keywords, so it can escape them as raw identifiers when pretty-printing. Since Camlp5 supports more than one syntax, that means different syntaxes can have different sets of identifiers. Hence, the lexer has to support exposing the set of keywords, and the pretty-printer has to support being parameterized by the keywords. matita creates a Camlp5 lexer, so it needs to be changed to have that keyword-table slot (even though it seems it doesn't use it).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello, here is a tiny patch that seems to work. I don't know much about matita, so this could be incorrect. I'll be releasing a new version of Camlp5, marking it incompatible with matita <= 0.99.5 (b/c build fails). I'd be happy to help you figure out what a better fix is, if this one isn't suitable.
===================
This breaks compat with previous versions of Camlp5
OCaml 5.2.0 supports raw identifiers, e.g. "\begin". The Camlp5 pretty-printer needs to know which "identifier-like" strings are keywords, so it can escape them as raw identifiers when pretty-printing. Since Camlp5 supports more than one syntax, that means different syntaxes can have different sets of identifiers. Hence, the lexer has to support exposing the set of keywords, and the pretty-printer has to support being parameterized by the keywords.
matita creates a Camlp5 lexer, so it needs to be changed to have that keyword-table slot (even though it seems it doesn't use it).