-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow user to add custom codecEngine #27
base: master
Are you sure you want to change the base?
Conversation
Hi @AUT0CRAT , will take a look at PR and get back to you 👍 |
@AUT0CRAT Could you please provide an example of how the codec is used, possibly adding some testing code to Main class? |
Hi @AUT0CRAT , it will be helpful if you can provide working example. I will try to integrate it by trying out send method with binary data. |
|
||
List<Object> a = new ArrayList<>(); | ||
a.add(dataObject.optString("channel")); | ||
a.add(dataObject); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should probably be fixed as: a.add(dataObject.optJSONObject("data"));
Hi @XDex , if you know how to use code defined in PR, it will be useful if you can post working example here 👍 or create PR for it. |
@sacOO7 Actually, I'm now working on adding support for |
Hi @XDex , I don't think making a separate project a good idea. We have already decided to keep one client per language (since too many clients is creating problem for users to choose one) . It's better if we can keep it at one place. It's easy to maintain that way, and also people can raise and find issues at one place. I don't think 3-4 class files for managing codecs will make implementation heavy as a library .. |
HI @XDex , do you have any plans to release library with sc codec min? I mean we can conclude on solution which will work for us... Even keeping the library size as small as possible... |
PR for #10
A basic implementation of Binary Codec for JAVA client.