Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: background line thickness settings added #1192

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

arpandaze
Copy link
Contributor

Adds settings to control the thickness of background lines.

Copy link
Member

@adil192 adil192 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is cool, can you just refactor lineWeight to lineThickness. Atm it looks too similar to lineHeight!

@arpandaze arpandaze force-pushed the background-line branch 2 times, most recently from 834e687 to 4951224 Compare November 13, 2024 15:12
@arpandaze
Copy link
Contributor Author

This is cool, can you just refactor lineWeight to lineThickness. Atm it looks too similar to lineHeight!

Sure. I have just refactored it into lineThickness but pipeline seems to be failing due to late initialization in 1 test. I have also added default value for the preference but not sure why its throwing error. Can you please let me know how to fix this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants