Move selection to another page #1085
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1085 +/- ##
==========================================
+ Coverage 35.95% 37.07% +1.12%
==========================================
Files 115 110 -5
Lines 9076 8675 -401
==========================================
- Hits 3263 3216 -47
+ Misses 5813 5459 -354 ☔ View full report in Codecov by Sentry. |
Undo/redo is not handled correctly because old items are deleted and new created.
In Select added pageIndexStart holding original page of selection. In EditorHistory added pageIndexStart - important only for move Solving issue saber-notes#932
adil192
force-pushed
the
MoveSelectionToAnotherPage
branch
from
b5c1609
to
d5b7142
Compare
…selection movement is stored to history. This fixes problem when selection is moved across pages, and then moved on page (in this case pageIndexStart was set according to the first movement of selection)
|
What is the status here? What is blocking this MR? |
|
I hope that from my side is all done. |
|
Thank you for coming back to this, I'm also patiently waiting for this to get resolved. From what I understand, the status of this Pull Request is "This branch has conflicts that must be resolved". Maybe there are conflicting changes with the current state of the main branch? |
Yes, but this conflict can resolve only person with write access to repository, and I have no write access. |
|
I tried to solve problem but one of the tests did not passed. @adil192, can you resolve it please. I have no idea how to improve my pull request more. |
|
@QubaB I am not sure about the rebase, there seems to be quite a huge amount of changes (many more files than before), I am not sure if this is intended. |
|
I merged current main to my branch to be able to handle problem with commit in editor.dart (editor.dart was improved since Dec 2023). I am not familiar too much with merging branches. I hope @adil192 can manage it somehow. |
|
Any updates on this? |
Implemented moving selection across pages. Undo/redo works.
In Select added pageIndexStart holding original page of selection.
In EditorHistory added pageIndexStart - important only for move
In Editor is mainly change onDrawUpdate which should handle moving items to another page.
Closes #932