This repository has been archived by the owner on Oct 2, 2022. It is now read-only.
Update dependencies #4
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey, Thanks for the PR. I prefer to keep vendor since go relies on code being checked into github. The second a dependency(repo) is deleted, this project is SOL. Until there's a central storage solution that cannot be removed, committing vendor is necessary. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is split in 3 commits that:
vendor/directory from the repositoryThe last one I did because I don't want to clutter the history of the repository with stuff that can be retrieved from elsewhere. It is already quite heavy (103 MiB for 279 KiB of original code). But maybe you have a good reason that it's here in the first place.
I tested it and it seems to work fine. The Dockerfile seems to build fine too.