Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix for "Can't resolve 'fs'" #84

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Fix for "Can't resolve 'fs'" #84

wants to merge 2 commits into from

Conversation

ouroboroscoding
Copy link

Added "browser" section to package.json so that csv-writer continues to work with latest version of React/node/npm

@ouroboroscoding
Added "browser" section to package.json so that csv-writer continues …
fc58569 
…to work with latest version of React/node/npm
@ouroboroscoding ouroboroscoding mentioned this pull request Mar 19, 2022
Open
@ypresto
Copy link

ypresto commented Apr 28, 2023

This PR should not be merged as-is because it changes package metadata. Could you create separate branch for publishing and for PR?

@ypresto
Copy link

ypresto commented Apr 28, 2023

Also we need to set csvWriter.fileWriter = by hand to avoid calling fs.writeFile().
It should have a new function which returns JS string (createCsvTextWriter or something).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ouroboroscoding @ypresto