-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add high precision scrolling. #86
base: master
Are you sure you want to change the base?
Conversation
Please resubmit this PR against the dev branch if you can. |
Nevermind, I've manually merged the changes with dev at lsr0-master. |
I've begun testing this and it's finicky at best. I have some theories as to why this is but I can't merge it in, much less make it the default mode, given its current state. |
Interesting. Can you give any more detail on the issue(s)? I've been using it for about 3 months on my primary machine at this point and haven't noticed any issues barring applications without good handling for high precision scroll events. |
It seems to lock itself into scrolling mode sometimes so that a single finger will cause scrolling. The reverse is also true, where sometimes after scrolling I will need two fingers to move the cursor. |
return BadMatch; | ||
|
||
if (!checkonly) { | ||
cfg->scroll_high_prec = ivals32[0]; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ivals32 ivals8
I've been running this on my main computer for a couple months now and it works flawlessly. If I clean up the style issues, are you interested in merging this? |
@thirtythreeforty: I'll admit you reminded me to fix the issues raised by @p2rkw. This is now done. @bluedragonx: Any further findings on the issue? My only suspicion is that because the multitouch code path doesn't call |
Adds high precision scroll events -- informing Xorg of scrolling via motion events with distance values rather than through button click events.
Added a configuration option (and entry to README.md) to turn it on/off - ScrollHighPrecision.
In this patch set, that option defaults to on.
Tested in a variety of Qt apps + firefox-gtk3.