Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add high precision scrolling. #86

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Add high precision scrolling. #86

wants to merge 5 commits into from

Conversation

lsr0
Copy link

@lsr0 lsr0 commented May 1, 2015

Adds high precision scroll events -- informing Xorg of scrolling via motion events with distance values rather than through button click events.

Added a configuration option (and entry to README.md) to turn it on/off - ScrollHighPrecision.

In this patch set, that option defaults to on.

Tested in a variety of Qt apps + firefox-gtk3.

@rynbrd
Copy link
Owner

rynbrd commented Jul 27, 2015

Please resubmit this PR against the dev branch if you can.

@rynbrd
Copy link
Owner

rynbrd commented Jul 27, 2015

Nevermind, I've manually merged the changes with dev at lsr0-master.

@rynbrd
Copy link
Owner

rynbrd commented Jul 27, 2015

I've begun testing this and it's finicky at best. I have some theories as to why this is but I can't merge it in, much less make it the default mode, given its current state.

@lsr0
Copy link
Author

lsr0 commented Jul 27, 2015

Interesting. Can you give any more detail on the issue(s)? I've been using it for about 3 months on my primary machine at this point and haven't noticed any issues barring applications without good handling for high precision scroll events.

@rynbrd
Copy link
Owner

rynbrd commented Jul 27, 2015

It seems to lock itself into scrolling mode sometimes so that a single finger will cause scrolling. The reverse is also true, where sometimes after scrolling I will need two fingers to move the cursor.

return BadMatch;

if (!checkonly) {
cfg->scroll_high_prec = ivals32[0];
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ivals32 ivals8

@thirtythreeforty
Copy link

I've been running this on my main computer for a couple months now and it works flawlessly. If I clean up the style issues, are you interested in merging this?

@lsr0
Copy link
Author

lsr0 commented Oct 6, 2015

@thirtythreeforty: I'll admit you reminded me to fix the issues raised by @p2rkw. This is now done.

@bluedragonx: Any further findings on the issue? My only suspicion is that because the multitouch code path doesn't call trigger_button_click() and therefore doesn't set button_delayed_time et al, some button related handling differs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants