Miscellaneous fixes #109
Open
Miscellaneous fixes #109
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
(EE) BUG: triggered 'if (f[f_idx])' (EE) BUG: ../../os/log.c:565 in vpnprintf() (EE) Unsupported printf directive '+'
Otherwise we get an implicit declaration warning about mtdev_empty. Signed-off-by: Ian Jackson <[email protected]>
Otherwise we get an implicit declaration warning about close(). Signed-off-by: Ian Jackson <[email protected]>
This is a printf format specifier, a la PRIx32 et al. This avoids us having to write %#x explicitly, which would be annoying if bitmask_t ever changed its type. No use sites introduced in this commit, so no functional change yet. Signed-off-by: Ian Jackson <[email protected]>
The user is expected to decode the hex (with reference to the bit numbers defined in mtstate.h). Signed-off-by: Ian Jackson <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While debugging a problem with button zones, I found these patches useful and/or necessary. They mostly stand alone.