Food #446
Draft
Food #446
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Glinkis
reviewed
Dec 23, 2020
Comment on lines
+58
to
+60
| isVegetarian?: boolean | ||
| /** Flagging `isVegan` will automatically flag `isVegetarian` as true. */ | ||
| isVegan?: boolean |
There was a problem hiding this comment.
These could probably be combined into a single attribute. Perhaps something along the lines of diet: "vegan".
There was a problem hiding this comment.
I was thinking that the simplest way to calculate veganocity would be an optional override, and then a simple if statement to check whether there were any ingredients that broke the conduct.
There was a problem hiding this comment.
Hm, seems it might break the single source of truth principle. Perhaps we could use an isVegan, and isVegetarian function to check it at runtime instead?
There was a problem hiding this comment.
And then we don't need the flags to be on the object, as they're calculated instead of explicitly set.
Glinkis
reviewed
Dec 23, 2020
Glinkis
reviewed
Dec 23, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this do?
Adds a more robust food generation system.
How was this tested? Did you test the changes in the compiled
.htmlfile?Still in draft.
Is there a GitHub Issue that this is resolving?
Closes #70.