Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implemented handling of URLs with pagination segments for PagePathHistory module #1036

Open
wants to merge 1 commit into
base: dev
Choose a base branch
from
Open

Implemented handling of URLs with pagination segments for PagePathHistory module #1036

wants to merge 1 commit into from

Conversation

bfncs
Copy link

@bfncs bfncs commented Mar 22, 2015

The core module PagePathHistory didn't handle URLs with pagination segments until now.

Steps to reproduce the problem

  1. Create a page with working pagination handling and markup so, that the following URLs are handled by that page:
    • /objects/
    • /objects/page2
    • /objects/page3
    • …and so on.
  2. Enable the PagePathHistory module in the admin.
  3. Rename the objects page to objects-new.
  4. Requesting the now deprecated URL without pagination segment /objects/ works flawlessly by redirecting to the now correct URL /objects-new/ .
  5. Requesting one of the now deprecated URLs with pagination segment, e.g. /objects/page2 leads to a 404 Page not found error instead of redirecting to the now correct URL /objects-new/page2.

Patch

This patch adds basic handling of URLs with pagination segments to PagePathHistory. Redirection after changing page URL prefixes is not supported, though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants