This repository has been archived by the owner on Feb 26, 2020. It is now read-only.
Added caching and Django CMS 3.3 compatibility #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I realized that it is really hard to invalidate the cache properly... It actually works fine for pages but I wasn't able to refresh the menu when using AppHook menus. So feel free to just close this PR. If you think it is still useful a settings flag might be useful. |
|
Turns out, the cache invalidation was correct. What was missing for me was the Django CMS menu cache invalidation - which is an additional cache indepent from this implementation - when updating objects from my app. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.