This repository has been archived by the owner on Jun 22, 2022. It is now read-only.
feat(stochastic): log out metrics for all handlers in LambdaRuntime. #88
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ryan-mars
reviewed
Jul 6, 2021
ryan-mars
reviewed
Jul 6, 2021
ryan-mars
reviewed
Jul 7, 2021
|
Ugh, the build is failing because of that annoying CDK version bug but it isn't happening locally... Will fix tomorrow. Should we try CDK 2.0? I worry about this for stochastic users. |
|
I also consolidated our jest configurations into one |
sam-goodwin
commented
Jul 13, 2021
ryan-mars
reviewed
Jul 13, 2021
examples/airline/scheduling/src/__snapshots__/service.test.ts.snap
Outdated
Show resolved
Hide resolved
I have no problem with moving to CDK 2.0 now. |
|
ryan-mars
approved these changes
Jul 15, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds metrics and dashboards for #83
Closes #60
Closes #89
Closes #101
This change instruments our Command and Policy handlers to capture granular metrics such as the timing and success/fail rate of handling an event in a particular policy. We leverage the domain graph model to automatically track these granular merics and add them to a CloudWatch dashboard. The dashboards are a separate CDK stack than the BoundedContext to separate concerns. Not sure if this is a premature optimization.
Example dashboard:
See how the Policy dashboard has a metric for each event the Policy handles. We have similar metrics for the Command, tracking which Events were emitted by it.