Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable Trade/Transport/Caravan Session Buttons for Other Factions #507

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

SaberShip
Copy link
Contributor

@SaberShip SaberShip commented Sep 21, 2024

Probably mark as low priority.

What does it do

  • Disables buttons, checkboxes, and textboxes in caravan forming, load transport, and trade UI for factions not participating.
  • Also fixes broken tab width in trade window since 1.5
  • Prevents trade window from auto switching to your friend's active trade when you cancel or complete your own.

Alternate Solution?

If RWMT prefers it, I can pivot to a simpler solution of just hiding session dialogs from other factions all together. Its more simple and has fewer harmony patches, but in my opinion feels like it serves to isolate players from one another more. Making the multiplayer experience feel more like "single player at the same time".

In the future, perhaps both solutions have merit when faction relations are considered. Enemies have sessions hidden, neutral/friendly can view only.

Notes

There is probably a better way to do this, I just wanted to see if I could do it and learn how. Definitely open to suggestions/improvements.

Why not caravan splitting session? - It seems that in multifaction, other factions cannot see the splitting session and there may be a bug in async-time preventing all maps from unpausing while the splitting session is open.

Why not Ritual session or x session? - I don't own those DLC to test them. Others are welcome take what I've done here, improve it and apply it to those sessions.

Images:

Trade as seen from another faction:
image

Transport pod (similar to Caravan Forming):
image

@rautamiekka
Copy link

Disabling and explaining why it's disabled is a way better UX than outright removing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants